Add some bsp driver for HC32F4A8. #10333
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds support and driver updates for the HC32F4A8 MCU variant, extending existing HAL layers and board configurations.
- Enable HC32F4A8 in RTC, PM, MCAN, ETH, and DAC drivers
- Introduce VBAT power-down check for RTC initialization
- Update board-specific ports, Kconfig entries, and application code for F4A8
Reviewed Changes
Copilot reviewed 24 out of 24 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| bsp/hc32/libraries/hc32_drivers/drv_rtc.c | Add F4A8 support and VBAT power-down check |
| bsp/hc32/libraries/hc32_drivers/drv_pm.h | Extend EFM readiness check to F4A8 |
| bsp/hc32/libraries/hc32_drivers/drv_pm.c | Include F4A8 in deep-sleep and run-mode transitions |
| bsp/hc32/libraries/hc32_drivers/drv_mcan.c | Update MCAN ISR to accept int_sel parameter |
| bsp/hc32/libraries/hc32_drivers/drv_eth.c | Adapt PHY address handling and auto-negotiation config for F4A8 |
| bsp/hc32/libraries/hc32_drivers/drv_dac.h | Extend DAC init struct with new F4A8 channel parameters |
| bsp/hc32/libraries/hc32_drivers/drv_dac.c | Implement channel init logic for F4A8 DAC ports |
| bsp/hc32/ev_hc32f4a8_lqfp176/board/{ports,config,board_config.c,hc32f4xx_conf.h,Kconfig} | Add board-level port mappings, DAC/Kconfig updates, and FCM application changes for F4A8 |
Comments suppressed due to low confidence (2)
bsp/hc32/libraries/hc32_drivers/drv_rtc.c:202
- [nitpick] The function
VBAT_PowerDownCheckuses PascalCase and no underscore prefix, which is inconsistent with other static helper functions; consider renaming to_vbat_power_down_checkto match existing naming conventions.
static en_flag_status_t VBAT_PowerDownCheck(void)
bsp/hc32/libraries/hc32_drivers/drv_mcan.c:862
- The
mcan_isrdefinition was changed to accept two parameters, but any forward declarations or other references expecting a single-parameter signature will break; ensure the prototype is updated everywhere (including headers) to match this new signature.
rt_inline void mcan_isr(hc32_mcan_driver_t *driver, uint32_t int_sel)
这个PR还有什么问题要处理吗？没有看到新的异常 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
拉取/合并请求描述：(PR description)
[
Add some bsp driver for HC32F4A8.
]
当前拉取/合并请求的状态 Intent for your PR
必须选择一项 Choose one (Mandatory):
代码质量 Code Quality：
我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:
#if 0代码，不包含已经被注释了的代码 All redundant code is removed and cleaned up